Skip to content

Show IP address on workspace_build audit logs #5268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #4726
Kira-Pilot opened this issue Dec 2, 2022 · 2 comments · Fixed by #5997
Closed
Tracked by #4726

Show IP address on workspace_build audit logs #5268

Kira-Pilot opened this issue Dec 2, 2022 · 2 comments · Fixed by #5997
Assignees
@Kira-Pilot

Comments

@Kira-Pilot
Copy link
Member

Screen Shot 2022-12-02 at 4 11 51 PM

The IP address on workspace_build audit logs shows as 'Not Available' in our UI. This is because there is not (an obvious) way to access the initiator of the request, or the request itself.

During our Audit Log demos, it was indicated this information is very important to auditors, so we should investigate methods to pass it along, if possible.
@Kira-Pilot Kira-Pilot mentioned this issue Dec 2, 2022
Closed
41 tasks
@kylecarbs
Copy link
Member

I also think Not Available is confusing because each request always is initiated from some IP.

@Kira-Pilot Kira-Pilot mentioned this issue Jan 3, 2023
Closed
@Kira-Pilot
Copy link
Member Author

Spoke with @kylecarbs and there really isn't an IP address for these logs. As such, the current label IP: not available is misleading and should be removed entirely.

@Kira-Pilot Kira-Pilot self-assigned this Jan 31, 2023
@Kira-Pilot Kira-Pilot mentioned this issue Feb 2, 2023
Merged
@Kira-Pilot Kira-Pilot mentioned this issue Mar 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kira-Pilot Kira-Pilot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: hide IP on workspace build logs coder/coder
2 participants
@kylecarbs @Kira-Pilot