Skip to content

Support HTTPS internal server schema in coder_app #5891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpmct opened this issue Jan 27, 2023 · 2 comments · Fixed by #8585
Closed

Support HTTPS internal server schema in coder_app #5891

bpmct opened this issue Jan 27, 2023 · 2 comments · Fixed by #8585
Assignees
@sreya
Labels
must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this.

Comments

@bpmct
Copy link
Member

bpmct commented Jan 27, 2023 •
edited
Loading

In Coder v1, we supported both http and https servers via dev URLs. If the user was running an app in their workspace with a self-signed certificate, Coder would essentially ignore/replace it with the valid certificate for dev URLs.

Screen Shot 2023-01-27 at 9 32 51 AM

We should do something similar for v2. Perhaps magically supporting https URLs in coder_app?

When I tried this, it didn't work

resource "coder_app" "backstage" {
  agent_id     = coder_agent.main.id
  slug         = "backstage"
  display_name = "backstage"
  url          = "https://localhost:4443"
  icon         = "/icon/code.svg"
  subdomain    = false
  share        = "owner"
}
coder@ok:~$ curl --insecure https://localhost:4443
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">

Screen Shot 2023-01-27 at 9 35 06 AM
@github-actions
Copy link

This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label May 14, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2023
@matifali matifali reopened this May 24, 2023
@matifali matifali removed the stale This issue is like stale bread. label May 24, 2023
@bpmct bpmct added this to the ❓Sprint 2 milestone Jun 21, 2023
@bpmct bpmct added the must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this. label Jun 21, 2023
@bpmct
Copy link
Member Author

bpmct commented Jun 26, 2023

Some thoughts on how this could work:

  • The user doesn't have to do anything except specify https in their URL
  • Like Coder v1, we use the Coder certififcate, not self-signed certs the app may be serving

@ammario ammario removed this from the ❓Sprint 2 milestone Jun 29, 2023
@sreya sreya mentioned this issue Jul 19, 2023
Merged
@sreya sreya self-assigned this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sreya sreya

Labels
must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support localhost apps running https coder/coder
4 participants
@sreya @ammario @matifali @bpmct