-
Notifications
You must be signed in to change notification settings - Fork 881
Ensure Site owners cannot be transferred #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is this something we want to enforce or restrict because it's a best practice thing? Or is this from specific customer feedback that we've already validated in the past? |
Hey team! Please add your planning poker estimate with ZenHub @johnstcn @Emyrk @f0ssel |
@misskniss I'm not 100% clear on what this issue is asking for. When you set up coder for the first time, it prompts for an initial user creation step. This user is automatically granted the admin role, which is a built-in role like "site manager" in v1. There does not appear to be anything overly special about this initial user. My interpretation of the description is that it is asking us to ensure that there can only be one user with the site admin role at a time. Is my understanding correct? If so, I'm not sure I understand how this feature is useful. Has someone specifically asked for this functionality? |
@johnstcn no one has specifically asked for it. This was kinda taken from how github does it, and forces at least 1 user to be the "owner". This prevents locking yourself out of an org, as the org could be left with no "org-admins". That being said, we do have a site wide admin that could resolve this lock out. So the "owner" stuff isn't strictly required as there is a way around this. |
Ah, so the stipulation then becomes "there must be at least one org admin". That makes sense. |
This is done in this PR: #1406 |
As a site owner, I do not want my Site ownership to be allowed to be transfered to a user because the intent is that the site owner is a general non-person owner (like a generic company email).
The text was updated successfully, but these errors were encountered: