Skip to content

rich parameters: improve UX #6076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mtojek opened this issue Feb 7, 2023 · 4 comments
Closed

rich parameters: improve UX #6076

mtojek opened this issue Feb 7, 2023 · 4 comments
Assignees
Labels
parameters Area: parameters

Comments

@mtojek
Copy link
Member

mtojek commented Feb 7, 2023

Extracted from: #5574 (comment)

We'd like to improve the UX of rich parameters to be more consistent.

Ideas:

  1. Make the edit workspace form look the same as the create workspace form.
  2. Mutable/immutable headers seem odd.
  3. "Danger zone" around immutables, like img.
  4. Explain what it means in a description/subtitle in the form.
Original post

@deansheather:

can we make the edit workspace form look the same as the create workspace form?
like in v1
and just disable the fields that can't change
also the mutable/immutable headers seem odd to me, it'd be nice if users could define their own sections and we just relied on the yellow text that says it can't be changed instead

@ammario

What’s friendlier language we can use instead of “mutable” and “immutable” in the form? I also second Dean’s point. It would be cool if we could reuse the form and show the immutable params as disabled forms so the user is still aware of them. I also think it would be nice if we had a box around the immutable parameters like: https://i.imgur.com/tQ0TOhf.png.

@kylecarbs

i feel like immutable is pretty friendly as code

@ammario

As a section title it’s probably fine since it maps to configuration. We should at least explain what it means in a description / subtitle in the form.

@mtojek
Copy link
Member Author

mtojek commented Feb 7, 2023

Hey @BrunoQuaresma, is this something you can help with and park on your personal roadmap?

@BrunoQuaresma
Copy link
Collaborator

Sure thing! I have a few things on my plate right now but I can finish this probably next week.

@BrunoQuaresma BrunoQuaresma self-assigned this Feb 7, 2023
@mtojek mtojek added the parameters Area: parameters label Feb 28, 2023
@mtojek
Copy link
Member Author

mtojek commented Mar 13, 2023

@BrunoQuaresma I don't see the PR linked here. Could you please link it and resolve this issue/comment on the status?

@BrunoQuaresma
Copy link
Collaborator

From all the items posted, we are missing the "Make the edit workspace form look the same as the create workspace form.". I will do it next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parameters Area: parameters
Projects
None yet
Development

No branches or pull requests

2 participants