Skip to content

audit: logs for new OIDC Users #6108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #4726
MichaelGerhart opened this issue Feb 8, 2023 · 1 comment · Fixed by #6733
Closed
Tracked by #4726

audit: logs for new OIDC Users #6108

MichaelGerhart opened this issue Feb 8, 2023 · 1 comment · Fixed by #6733
Assignees
@Kira-Pilot
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.

Comments

@MichaelGerhart
Copy link

MichaelGerhart commented Feb 8, 2023 •
edited
Loading

Problem Summary

After implementation of #5925 user logins are getting appropriately audited, however if a NEW OIDC users logs in that does not have a local Coder user profile yet, the audit log shows "an unknown user logged in" creating a less than useful audit log message.

image

Expected Behavior

Coder should likely be creating the local user profile and then creating the audit record.

Steps To Reproduce The Problem

  1. Install coder and setup OIDC Authentication
  2. login with OIDC as a new user
@Kira-Pilot
Copy link
Member

Hi @MichaelGerhart! Thank you for documenting this. I'll add it to our audit epic.

This was referenced Feb 8, 2023
Closed
Closed
@bpmct bpmct added bug s2 Broken use cases or features (with a workaround). Only humans may set this. s1 Bugs that break core workflows. Only humans may set this. and removed s2 Broken use cases or features (with a workaround). Only humans may set this. labels Feb 9, 2023
@bpmct bpmct changed the title bug: New OIDC Users aren't correctly audited at login audit: proper logs for new OIDC Users Feb 9, 2023
@bpmct bpmct removed bug s1 Bugs that break core workflows. Only humans may set this. labels Feb 9, 2023
@bpmct bpmct changed the title audit: proper logs for new OIDC Users audit: logs for new OIDC Users Feb 9, 2023
@Kira-Pilot Kira-Pilot mentioned this issue Mar 13, 2023
Closed
@bpmct bpmct added bug s2 Broken use cases or features (with a workaround). Only humans may set this. labels Mar 16, 2023
@Kira-Pilot Kira-Pilot self-assigned this Mar 20, 2023
@Kira-Pilot Kira-Pilot mentioned this issue Mar 22, 2023
Merged
@matifali matifali added the bug label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kira-Pilot Kira-Pilot

Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(audit): audit login/logout for new 3rd-party auth coder/coder
4 participants
@MichaelGerhart @matifali @Kira-Pilot @bpmct