Skip to content

template editor: build status: failed is alarming when I first enter #6120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpmct opened this issue Feb 8, 2023 · 4 comments · Fixed by #6701
Closed

template editor: build status: failed is alarming when I first enter #6120

bpmct opened this issue Feb 8, 2023 · 4 comments · Fixed by #6701
Assignees
@BrunoQuaresma
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic
Milestone
Template Editor GA

Comments

@bpmct
Copy link
Member

bpmct commented Feb 8, 2023

I actually think it should just kick off a build as soon as you enter

Screenshot 2023-02-08 at 3 33 23 PM
@kylecarbs
Copy link
Member

Maybe we just hide the status? I wouldn't want to automatically trigger, because it occupies a provisioner daemon.

@bpmct
Copy link
Member Author

bpmct commented Feb 8, 2023

makes sense to me

@bpmct bpmct added bug s3 Bugs that confuse, annoy, or are purely cosmetic labels Feb 10, 2023
@bpmct bpmct added this to the Template Web Editor GA milestone Mar 13, 2023
@BrunoQuaresma
Copy link
Collaborator

If we hide the status how the user knows if it is valid or not?

@BrunoQuaresma BrunoQuaresma self-assigned this Mar 20, 2023
@bpmct
Copy link
Member Author

bpmct commented Mar 20, 2023

I interpreted it as only hiding the status bar before the first run, not all the time

@BrunoQuaresma BrunoQuaresma mentioned this issue Mar 21, 2023
Merged
@matifali matifali added the bug label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
Template Editor GA
Development

Successfully merging a pull request may close this issue.

refactor(site): Only show status after first edition coder/coder
4 participants
@BrunoQuaresma @kylecarbs @matifali @bpmct