Skip to content

Test opening a PR from a fork (CI jobs check) #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1101
misskniss opened this issue Mar 29, 2022 · 6 comments
Closed
Tracked by #1101

Test opening a PR from a fork (CI jobs check) #653

misskniss opened this issue Mar 29, 2022 · 6 comments
Assignees
@jsjoeio
Labels
api Area: HTTP API
Milestone
V2 Beta

Comments

@misskniss
Copy link

misskniss commented Mar 29, 2022 •
edited by jsjoeio
Loading

Description

Run through contributing a PR from a fork to ensure CI works as expected.
@jsjoeio jsjoeio self-assigned this Mar 30, 2022
@misskniss misskniss added this to the V2 Beta milestone Apr 1, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 6, 2022

Need a GitHub admin to enable this in order to test.

@jsjoeio jsjoeio mentioned this issue Apr 6, 2022
Closed
@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 6, 2022

Here's what I see for the status checks.

image

I'm guessing I need an admin or someone to approve the checks.

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 12, 2022

Will revisit this after the repo is public. See #892 (comment)

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 15, 2022

Partially fixed by #1035

Example: #1042

We need to make a few more changes before we close out this ticket, specifically skip some checks that require secrets

@coadler
Copy link
Contributor

coadler commented Apr 25, 2022

This is fully working now with #1048.

Here's an example of a PR from an external contributor: #1025

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 25, 2022

Woohoo! Gonna close this then since it's done.

@jsjoeio jsjoeio closed this as completed Apr 25, 2022
@misskniss misskniss mentioned this issue May 9, 2022
Closed
45 tasks
@misskniss misskniss added the api Area: HTTP API label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
api Area: HTTP API
Projects
None yet
Milestone
V2 Beta
Development

No branches or pull requests
3 participants
@misskniss @jsjoeio @coadler