Skip to content

Accessurl without scheme:// breaks OIDC redirect #6547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Emyrk opened this issue Mar 10, 2023 · 0 comments · Fixed by #6548
Closed

Accessurl without scheme:// breaks OIDC redirect #6547

Emyrk opened this issue Mar 10, 2023 · 0 comments · Fixed by #6548
Assignees
@Emyrk
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.

Comments

@Emyrk
Copy link
Member

Emyrk commented Mar 10, 2023

We expect access-url to be set to http://domain.com, but we accept domain.com and silently fail in places where it is used. This should be fixed to error and tell the user to add a scheme.
@Emyrk Emyrk added the bug label Mar 10, 2023
@Emyrk Emyrk self-assigned this Mar 10, 2023
@Emyrk Emyrk mentioned this issue Mar 10, 2023
Merged
@bpmct bpmct added the s2 Broken use cases or features (with a workaround). Only humans may set this. label Apr 27, 2023
@matifali matifali added the bug label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Emyrk Emyrk

Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Disallow access urls without valid scheme coder/coder
3 participants
@Emyrk @matifali @bpmct