Skip to content

Web terminal: Press any key to retry lies and reconnects in situations where you don't want it #6732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mafredri opened this issue Mar 22, 2023 · 4 comments · Fixed by #9686
Closed

Web terminal: Press any key to retry lies and reconnects in situations where you don't want it #6732

mafredri opened this issue Mar 22, 2023 · 4 comments · Fixed by #9686
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this. site Area: frontend dashboard

Comments

@mafredri
Copy link
Member

mafredri commented Mar 22, 2023 •
edited
Loading

If I log out (Ctrl+D, or exit), the web terminal will show the following screen:

image

However, if I press "any key", nothing happens. I try A-Z, I try , ., [Enter] -> nothing happens. [Space] does seem to work.

Now, what's even more confusing is that it does work for keys I expect it not to. Modifiers like Command, Ctrl or Shift trigger it, which is wrong. Imagine I log out, then I type Cmd+W to close the web terminal, and it logs me back in just before the window closes.

Browser: Safari.
@mafredri mafredri added site Area: frontend dashboard bug labels Mar 22, 2023
@bpmct bpmct added the s2 Broken use cases or features (with a workaround). Only humans may set this. label Mar 27, 2023
@mafredri mafredri mentioned this issue May 26, 2023
Closed
@matifali
Copy link
Member

Also, keyboard shortcuts to copy and paste do not work.

@mafredri
Copy link
Member Author

Also, keyboard shortcuts to copy and paste do not work.

Could you expand on this a bit? I'm not seeing any issue on macOS with either Safari or Brave. I can paste from OS clipboard (Cmd+V) and I can also select text with my trackpad and hit Cmd+C to copy to the OS clipboard.

@matifali
Copy link
Member

matifali commented May 26, 2023 •
edited
Loading

I do not have a Mac, but on a Windows machine, it does not work on Brave.
Please take a look at the screen recording. The ^V and ^M characters appear when I press Ctrl+V and Ctrl+V+Enter

Recording.2023-05-26.180550.mp4

I see the same behaviour on Brave and Edge.

@mafredri
Copy link
Member Author

@matifali ah, I see what you mean. That's a bit problematic since Ctrl+C and Ctrl+V (e.g. in VIM, enters visual block mode) can be valid input in a terminal. I do see that cmd.exe and powershell allow this though and don't pass-through the input.

Perhaps we should move this to a new issue? It's separate from the retry issue and quite possibly only affects Windows.

@matifali matifali mentioned this issue May 26, 2023
Closed
@code-asher code-asher mentioned this issue Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this. site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reconnect terminal on non-modified key presses coder/coder
3 participants
@mafredri @matifali @bpmct