Skip to content

rich parameters: can't migrate to the template with coder_parameters #6734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtojek opened this issue Mar 22, 2023 · 2 comments · Fixed by #6740
Closed

rich parameters: can't migrate to the template with coder_parameters #6734

mtojek opened this issue Mar 22, 2023 · 2 comments · Fixed by #6740
Assignees
@BrunoQuaresma

Comments

@mtojek
Copy link
Member

mtojek commented Mar 22, 2023

Hi,

Screenshot 2023-03-22 at 17 19 19

This popup has been introduced to allow users to pass their own values for new required parameters. Unfortunately, it doesn't play well with migration flow. The migration flow assumes that if there is no workspace build parameters, but there is a legacy variable property present, coder backend will try to pull matching values from legacy parameters.

I guess that one of the options would be skipping rich parameters with extra property (legacy_variable_name)?

@bpmct @BrunoQuaresma
@BrunoQuaresma
Copy link
Collaborator

@mtojek what is the problem with the current flow?

This was referenced Mar 22, 2023
Merged
Merged
@mtojek
Copy link
Member Author

mtojek commented Mar 22, 2023 •
edited
Loading

Status update:

I found a bug in the terraform-provider-coder and updated the backend side. Once this gets merged, @BrunoQuaresma could you please adjust the frontend to obey the legacy_variable_name?

@BrunoQuaresma BrunoQuaresma mentioned this issue Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(site): Fix missing parameters detection on update workspace coder/coder
2 participants
@BrunoQuaresma @mtojek