Skip to content

bug: workspace screen not loading #6807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matifali opened this issue Mar 27, 2023 · 6 comments
Closed

bug: workspace screen not loading #6807

matifali opened this issue Mar 27, 2023 · 6 comments
Assignees
Labels
s0 Major regression, all-hands-on-deck to fix site Area: frontend dashboard

Comments

@matifali
Copy link
Member

Recording.2023-03-27.170542.mp4

Do you see how I cannot launch the workspace on the first click? This happens if another workspace is stopping or starting.

@BrunoQuaresma

@matifali matifali changed the title bug: workspace screen not leading bug: workspace screen not loading Mar 27, 2023
@BrunoQuaresma
Copy link
Collaborator

Thanks for sharing this!

@BrunoQuaresma BrunoQuaresma added bug site Area: frontend dashboard labels Mar 27, 2023
@bpmct bpmct added the s2 Broken use cases or features (with a workaround). Only humans may set this. label Mar 27, 2023
@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 27, 2023

Running into this as well.

@matifali
Copy link
Member Author

@BrunoQuaresma, I am unable to access my workspace now. Watch the screen recording.

Recording.2023-03-28.110704.mp4

@johnstcn johnstcn added s0 Major regression, all-hands-on-deck to fix and removed s2 Broken use cases or features (with a workaround). Only humans may set this. labels Mar 28, 2023
@johnstcn
Copy link
Member

johnstcn commented Mar 28, 2023

Root cause was that the WorkspacePage component was hitting /authcheck with the following payload:

{"checks":{"readPagePermissions":{"object":{"resource_type":"workspace"},"action":"read"}}}

This equates to asking "Can I read all workspaces?", which will not be true for a "Member".

The following payload returns {"readPagePermissions": true}:

{"checks":{"readPagePermissions":{"object":{"resource_type":"workspace", "resource_id": "$VALID_WORKSPACE_ID_OWNED_BY_REQUESTOR"},"action":"read"}}}

This came from the following:

  const { data: permissions, isLoading: isLoadingPermissions } =
    useReadPagePermissions("workspace", workspace?.id)
                                                 ^~~~~~~~~~~~~~~ here

As we're in the process of fetching the workspace by owner and name, we don't necessarily have the workspace ID available in the current context.

For the moment, I reverted the commit.

@johnstcn johnstcn self-assigned this Mar 28, 2023
@johnstcn johnstcn reopened this Mar 28, 2023
@johnstcn
Copy link
Member

Needs a release

@johnstcn
Copy link
Member

Fixed in v0.21.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s0 Major regression, all-hands-on-deck to fix site Area: frontend dashboard
Projects
None yet
Development

No branches or pull requests

5 participants