-
Notifications
You must be signed in to change notification settings - Fork 887
During auto shutdown, Coder submits old variables which can break the ability to shutdown #7073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We shall fix this! cc @mtojek |
Taking a look |
I reproduced a bit different issue, but I believe that the root cause is the same. What I did is:
|
Root cause: it seems to be related to the template version that is used. For some reason (a bug?), autostop uses the latest template version instead of the one that is assigned before the autostop event. |
Context: #6049 modified the autostart behaviour to automatically update the workspace to the latest template version. Previously, it would use the template version of the last successful build. |
@bpmct It seems that we have conflicting assumptions. Do you think that we should revert the auto-update? Otherwise, it will be either confusing for users ("did it update or not") or it will keep failing. |
I see. Why are we updating the version on stop instead of the next start? I guess we can disable the "auto-update" behavior for now, but I know some users are hoping to use Coder to ensure developers all stay on the same version. The behavior I would (eventually) expect is:
Seems like this would require significant rework though, so let's revert the auto-update for now. |
FYI "Autoupdate" has been reverted. |
I guess that I can close it now. |
I believe the repro is this:
I believe you'll get an error that looks like the following:
The text was updated successfully, but these errors were encountered: