-
Notifications
You must be signed in to change notification settings - Fork 886
bug: daily active users modal in Deployment tab is incorrect #7275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This might be a UTC vs local timezone thing. I will look into it. |
I hope to come back to this. If anyone else wants to, then can fix this. Pretty sure it is a UTC vs local timezone issue. We use UTC on the backend to generate these buckets. |
The issue is that the SQL query truncates the dates in UTC. So only UTC date buckets work.
The counting calculation is cached. See the counting here: coder/coderd/metricscache/metricscache.go Lines 138 to 142 in 84fb50b
|
Just realized the postgres does a Hmm 🤔 |
My PR describes what I implemented. This makes the response able to change in reference to the caller's local timezone. |
I'm going to reopen this until we change the frontend to show the proper values based on the user's timezone. There is a backend fix, but it's not really obvious/accessible for the user. |
customer daily active user count showed 16 on Sunday, which was incorrect, since no users had logged in. the figure was likely off by a day, since it showed 0 for the previous day, Saturday.
The text was updated successfully, but these errors were encountered: