-
Notifications
You must be signed in to change notification settings - Fork 889
workspace proxy enhancements #7397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Are proxies a replacement for HA? |
@matifali they are for reducing latency for geographically sparse teams like Coder's. You can host a proxy in regions far from the primary deployment and it will help make web connections faster and aid in speeding up CLI connections (proxies ones anyways). |
Regarding system service point:
Add basic docs for deploying on Kubernetes:
Add basic docs for deploying via docker run (most people will not use docker run but may try to run with app engine or AWS ECS
List latency in the picker in "Account" settings (#7381):
Automatically pick a workspace proxy based on latency (#7381):
Add a small section for troubleshooting proxies
coder proxy create does not feel as polished as coder user create or coder template create. Some other "rough" features have this (e.g. coder provisionerd create will panic) but I think the error handling could be improved/standardized a bit before we make this feature GA.
The 404 message on the proxy root endpoint is a bit jarring
Improve recovery time when a proxy goes offline, perhaps if it was gracefully stopped it can report shutdown to Coder?
What is the current behavior with #6592? Are workspace proxies still enabled when out-of-date?
... the agent disconnected for a second and it was another minute before I could open code-server (it was using the original address, but still not resolving). Does this have to do with some type of DERP disconnect?
|
This should aready be happening. I will check to confirm |
@deansheather I did not use a websocket to measure latency. I used the Performance API: https://developer.mozilla.org/en-US/docs/Web/API/Performance_API/Resource_timing See #7486 |
closing in favor of individual tickets opened |
👋🏼 I tried out workspace proxies and have some feedback on the feature. (I know it's still in MVP and some of these things are planned. I tried to write out everything I noticed)
Cool 😎
coder proxy create
for automationHigh user impact
Do proxies include DERP yet? It doesn't look like it from this tooltip, but I was also confused that in the instructions I should add this
CODER_DERP_SERVER_ENABLE=true CODER_DERP_SERVER_RELAY_ADDRESS="https://127.0.0.1:8443"
Assuming they don't 🤷🏼
Do not show a list of workspace proxies on the "account" page if there are no external proxies added
Typo on workspace proxies description (https://github.com/coder/coder/pull/7448/files)
to
Add latency indicator to web terminal (add latency indicator to web terminal #7382) (two people who tried thought that it wasn't enabled for the web terminal)
Add basic docs for deploying via a system service
Add basic docs for deploying on Kubernetes
Add basic docs for deploying via
docker run
(most people will not usedocker run
but may try to run with app engine or AWS ECSImprove "Route not found." error if no license is not present (chore: Make better error message if missing license #7440)
ubuntu@ben-coder:~$ coder proxy ls Route not found.
workspace proxies: DERP only #7374
Medium user impact
List latency in the picker in "Account" settings (workspace proxies: show latency indicator on dashboard #7381)
Automatically pick a workspace proxy based on latency (workspace proxies: auto-pick proxy with the best latency #7496)
Add lightweight workspace proxy picker in terminal latency hover (or link to account settings)?
coder proxy ls
shows status twiceubuntu@ben-coder:~$ coder proxy ls NAME URL STATUS STATUS japan-gcp unregistered
It is confusing for a proxy to not immediately become healthy when started, especially if it was unhealthy before. This is done, when a proxy is updated/created/registerd the status is checked async immediately. So it will come online as quickly as is possible, and ignore the normal 1min cadence.
Add a small section for troubleshooting proxies
Low user impact
coder proxy create
polish #7908$ coder proxy create ubuntu@ben-coder:~$ coder proxy create proxy name is required
Redesign workspace proxy picker to be a bit more slick, perhaps collaborate with Bruno on it?
The 404 message on the proxy root endpoint is a bit jarring
Improve recovery time when a proxy goes offline, perhaps if it was gracefully stopped it can report shutdown to Coder? chore: Implement workspace proxy going away (graceful shutdown) #7459
Unknown impact / open questions
coder proxy ls
? Is it worth documenting that an admin can hit this endpoint to get more detailsThe text was updated successfully, but these errors were encountered: