Skip to content

workspace actions: add deletion modal for previously inactive workspaces #7497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kira-Pilot opened this issue May 11, 2023 · 2 comments · Fixed by #7860
Closed

workspace actions: add deletion modal for previously inactive workspaces #7497

Kira-Pilot opened this issue May 11, 2023 · 2 comments · Fixed by #7860
Assignees
@Kira-Pilot
Milestone
🦛 Sprint 1

Comments

@Kira-Pilot
Copy link
Member

When a user sets an inactivityTTL in the template schedule page and there are already inactive workspaces that will be immediately scheduled to be deleted, we should inform the user and allow them to take action via a modal, e.g.

30 workspaces already match this filter. These workspaces will be scheduled for deletion in 14 days.
[Confirm] | [Cancel]

"Confirm" would go ahead and set the inactivityTTL, "Cancel" would cancel the action altogether. It would fall upon the user to do something about those 30 workspaces prior to going back and attempting to reset the inactivityTTL.
@Kira-Pilot Kira-Pilot self-assigned this May 11, 2023
@Kira-Pilot Kira-Pilot added this to the Workspace Actions GA milestone May 11, 2023
@Kira-Pilot
Copy link
Member Author

Kira-Pilot commented May 11, 2023 •
edited
Loading

Down the road, we should figure out a good way for the user to more easily identify those 30 workspaces. ATM the workflow would be filtering on inactive workspaces in the /workspaces page. Consider adding a link to this filter from within the modal.

@Kira-Pilot
Copy link
Member Author

Make sure we're accounting for workspaces that would already have been deleted, as well.

@sreya sreya added the sprint-0 label May 22, 2023
@ammario ammario removed the sprint-0 label May 22, 2023
@Kira-Pilot Kira-Pilot mentioned this issue Jun 5, 2023
Merged
@sreya sreya modified the milestones: 🧹 Sprint 0, ❓Sprint 1 Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kira-Pilot Kira-Pilot

Labels
None yet
Projects
None yet
Milestone
🦛 Sprint 1
Development

Successfully merging a pull request may close this issue.

feat: add impending deletion filter to workspaces page coder/coder
3 participants
@sreya @ammario @Kira-Pilot