Skip to content

condition deploy_template job on deploy_image job completion #7662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matifali opened this issue May 24, 2023 · 0 comments · Fixed by #7693
Closed

condition deploy_template job on deploy_image job completion #7662

matifali opened this issue May 24, 2023 · 0 comments · Fixed by #7693
Assignees
@matifali
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@matifali
Copy link
Member

matifali commented May 24, 2023 •
edited
Loading

Problem

When we make changes to https://github.com/coder/coder/blob/main/dogfood/Dockerfile, dogfood.yaml action deploys the template deploy_template asynchronously to deploy_image and the dogfood templates get updated before a newer image is updated so that update does not include the changes made in Dockerfile

coder/.github/workflows/dogfood.yaml

Line 51 in f47ecc2

deploy_template:

Solution

We should condition deploy_template job on deploy_image completion
@matifali matifali added bug s3 Bugs that confuse, annoy, or are purely cosmetic labels May 24, 2023
@matifali matifali changed the title condition template deploy on image-deploy condition deploy_template job on deploy_image job May 24, 2023
@matifali matifali changed the title condition deploy_template job on deploy_image job condition deploy_template job on deploy_image job completion May 24, 2023
matifali added a commit that referenced this issue May 26, 2023
@matifali
chore: Only run deploy_template after deploy_image has been compl…
63f6b48 
…eted.

This resolves #7662
@matifali matifali mentioned this issue May 26, 2023
Merged
@matifali matifali self-assigned this May 26, 2023
@matifali matifali added the bug label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matifali matifali

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Only run deploy_template after deploy_image has been completed coder/coder
1 participant
@matifali