Skip to content

Allow startup script notification in web terminal to be dismissible without reload #7760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
mafredri opened this issue Jun 1, 2023 · 1 comment · Fixed by #8019
Closed
2 tasks

Allow startup script notification in web terminal to be dismissible without reload #7760

mafredri opened this issue Jun 1, 2023 · 1 comment · Fixed by #8019
Assignees
@rodrimaia
Labels
site Area: frontend dashboard

Comments

@mafredri
Copy link
Member

mafredri commented Jun 1, 2023

Currently the startup script notification is always visible in the web terminal while it's running and the only way to dismiss it is by pressing "Reload" which discards the current terminal session.

If the startup script failed, the notification is never dismissible which can be annoying for users.

  • Add x that dismisses the notification without discarding the session
  • Show x when startup script failed as well

Future improvement ideas:

  • Remember that x was pressed for unique workspace build/agent ID in local storage and dismiss it from all opened web terminals for said build
@mafredri mafredri added feature site Area: frontend dashboard labels Jun 1, 2023
This was referenced Jun 1, 2023
Closed
Closed
@MrPeacockNLB
Copy link
Contributor

Currently we are using danamic startup-scripts so the behaviour can be different and this causes sometimes that a blocking process (has to be fixed) show this message. Even it is correct to show this warning one can not remove this to get full terminal size.

Thumbs up for hiding this message

@rodrimaia rodrimaia mentioned this issue Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrimaia rodrimaia

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(site): add documentation links to webterminal notifications coder/coder
4 participants
@mafredri @rodrimaia @BrunoQuaresma @MrPeacockNLB