Skip to content

flake: leak in logFollower #7791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
datadog-coder-official bot opened this issue Jun 2, 2023 · 0 comments · Fixed by #7792
Closed

flake: leak in logFollower #7791

datadog-coder-official bot opened this issue Jun 2, 2023 · 0 comments · Fixed by #7792
Assignees
@spikecurtis

Comments

@datadog-coder-official
Copy link

See example failure here.

Error logs:

goleak: Errors on successful test run: found unexpected goroutines:

[344](https://github.com/coder/coder/actions/runs/5150396317/jobs/9274475775#step:5:345)[Goroutine 175667 in state chan send, with github.com/coder/coder/coderd.(*logFollower).listener on top of the stack:

[345](https://github.com/coder/coder/actions/runs/5150396317/jobs/9274475775#step:5:346)goroutine 175667 [chan send]:

[346](https://github.com/coder/coder/actions/runs/5150396317/jobs/9274475775#step:5:347)github.com/coder/coder/coderd.(*logFollower).listener(0xc013655ea0, {0xc012d53f48?, 0x48d9de?}, {0xc0248b7110, 0x26, 0x30}, {0x0, 0x0})

[347](https://github.com/coder/coder/actions/runs/5150396317/jobs/9274475775#step:5:348) /home/runner/actions-runner/_work/coder/coder/coderd/provisionerjobs.go:418 +0x12a

[348](https://github.com/coder/coder/actions/runs/5150396317/jobs/9274475775#step:5:349)github.com/coder/coder/coderd/database.(*msgQueue).run(0xc0315ae000)

[349](https://github.com/coder/coder/actions/runs/5150396317/jobs/9274475775#step:5:350) /home/runner/actions-runner/_work/coder/coder/coderd/database/pubsub.go:97 +0x243

[350](https://github.com/coder/coder/actions/runs/5150396317/jobs/9274475775#step:5:351)created by github.com/coder/coder/coderd/database.newMsgQueue

[351](https://github.com/coder/coder/actions/runs/5150396317/jobs/9274475775#step:5:352) /home/runner/actions-runner/_work/coder/coder/coderd/database/pubsub.go:69 +0x1a5

[352](https://github.com/coder/coder/actions/runs/5150396317/jobs/9274475775#step:5:353)]

[353](https://github.com/coder/coder/actions/runs/5150396317/jobs/9274475775#step:5:354)FAIL github.com/coder/coder/cli 73.890s

@spikecurtis — seems likely related to #7712. Can you take a look at this?
@cdr-bot cdr-bot bot added the bug label Jun 2, 2023
@spikecurtis spikecurtis self-assigned this Jun 2, 2023
@spikecurtis spikecurtis added this to the 🧹 Sprint 0 milestone Jun 2, 2023
@spikecurtis spikecurtis mentioned this issue Jun 2, 2023
Merged
@ammario ammario removed this from the 🧹 Sprint 0 milestone Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: select on context to avoid leak in logFollower coder/coder
2 participants
@spikecurtis @ammario