Skip to content

bug: ci/deploy job fails with error #7887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnstcn opened this issue Jun 7, 2023 · 4 comments · Fixed by #7888
Closed

bug: ci/deploy job fails with error #7887

johnstcn opened this issue Jun 7, 2023 · 4 comments · Fixed by #7888
Assignees
@johnstcn
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@johnstcn
Copy link
Member

johnstcn commented Jun 7, 2023

After #7884 the ci/deploy job has been failing with the following error:

cli/server_slim.go:33:123: cliui.Styles.Code undefined (type cliui.Styles has no method Code)

Examples:
@johnstcn johnstcn added the bug label Jun 7, 2023
@johnstcn johnstcn mentioned this issue Jun 7, 2023
Closed
@matifali
Copy link
Member

matifali commented Jun 7, 2023

We skip the deploy job in PR tests. May it is time to have PR environments/deployments then we can catch such issues before they are merged into the main.

@matifali matifali added the s3 Bugs that confuse, annoy, or are purely cosmetic label Jun 7, 2023
@johnstcn johnstcn self-assigned this Jun 7, 2023
@johnstcn johnstcn mentioned this issue Jun 7, 2023
Merged
@johnstcn
Copy link
Member Author

johnstcn commented Jun 7, 2023

PR environments are great but have their own issues.

I don't think we actually run make build outside of the deploy job in the ci action; that would have caught the root cause of this. (At least, running a build locally reproduced the error for me.)

@matifali
Copy link
Member

matifali commented Jun 7, 2023

ok, so the issue is with the build and not deployment as the build failed.

@johnstcn johnstcn mentioned this issue Jun 7, 2023
Closed
@johnstcn
Copy link
Member Author

johnstcn commented Jun 7, 2023

Filed #7891 as a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnstcn johnstcn

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): remove remaining references to cliui.Styles.Code coder/coder
2 participants
@johnstcn @matifali