Skip to content

ci: build and publish a docker image against every merged commit to main #7916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matifali opened this issue Jun 8, 2023 · 4 comments
Closed

ci: build and publish a docker image against every merged commit to main #7916

matifali opened this issue Jun 8, 2023 · 4 comments
Labels
stale This issue is like stale bread.

Comments

@matifali
Copy link
Member

matifali commented Jun 8, 2023

We can use the following tags

  1. main
  2. edge
  3. $GIT_REVISION_SHORT

Also proposed by @johnstcn in #7891 (comment)

cc: @deansheather
@cdr-bot cdr-bot bot added the feature label Jun 8, 2023
@matifali matifali added the chore label Jun 8, 2023
@atnomoverflow
Copy link
Contributor

atnomoverflow commented Jun 8, 2023 •
edited
Loading

Also i think the go tests should not run on every pull requests you can trigger test when changes happen to certain places

@matifali
Copy link
Member Author

matifali commented Jun 8, 2023

Also i think the go tests should not run on every pull requests you can trigger test when changes happen to certain places

We have WIP PR to resolve this. See #7134. We plan to remove unnecessary tests in the future.

@ammario ammario removed the feature label Jun 8, 2023
@matifali matifali mentioned this issue Jun 11, 2023
Closed
@matifali
Copy link
Member Author

@bpmct what are your thoughts here?

@github-actions github-actions bot added the stale This issue is like stale bread. label Dec 11, 2023
@matifali
Copy link
Member Author

We are doing this now, and images are available as ghcr.io/coder/coder-preview for the last seven days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ammario @matifali @atnomoverflow