-
Notifications
You must be signed in to change notification settings - Fork 885
Flake in test-js #7948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I tried to reproduce this flake locally by running it 1000 times with Jest's Given this test has been in production for over a year without flaking continuously, I am wondering if the culprit is actually the same CI agent flake we've been running into on the Go side? I notice we are actually opening the workspaceagent websocket in this test - perhaps we could mock that out somehow instead to avoid this issue. |
It looks like we are mocking out the web socket, I think? We create a websocket with The linked run reports the string in the first row is Maybe if we check all the rows for the expected text instead of just the first one. |
Ah, you're right - I missed the mock. Good idea about xterm - I'll do some digging this week between sprint work. |
I have a feeling that it is stale issue. Feel free to reopen when it bumps up again. |
See example run
cc @coder/ts
The text was updated successfully, but these errors were encountered: