Skip to content

Remove VS Code Insiders hard-coded icon and make it site-wide optional #8032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sharkymark opened this issue Jun 14, 2023 · 2 comments
Closed

Comments

@sharkymark
Copy link
Contributor

Version: v0.24.1+2c843f4

No enterprise customer has requested this, and it should be removed by default. This appears to be a non-enterprise community member request #6267

I suggest a site-wide setting to enable it.

One of the core tenets of Coder is centralized control and putting an icon that is non-standard, where a majority of users may not even have VS Code Insiders installed on their local machine, making for a bad user experience and asking Coder for support.

Coder should not be in the business of hardcoding IDE icons except the baseline common ones. e.g., VS Code (latest) and someday JetBrains Gateway.

image

@mjasten32
Copy link

Agreed!

@matifali
Copy link
Member

matifali commented Sep 8, 2023

This is now possible after #9100

@matifali matifali closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants