Skip to content

templates: second level of approval for template changes #8216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ericpaulsen opened this issue Jun 26, 2023 · 3 comments
Closed

templates: second level of approval for template changes #8216

ericpaulsen opened this issue Jun 26, 2023 · 3 comments
Labels
enterprise Enterprise-license / premium functionality stale This issue is like stale bread.

Comments

@ericpaulsen
Copy link
Member

an enterprise prospect is evaluating Coder, and has provided feedback that a second stage of approval after coder templates push would be nice to have.

currently, template changes are handled directly from the template admin and are accepted as the source truth. instead, changes could just request code review of a peer prior to being pushed in. the template owner could be notified via email; "Request for a change in X template."

This will give more administration control to the flow, and will draw a clear line of responsibilities on who is the owner/responsible to maintain templates.
@ericpaulsen ericpaulsen added feature enterprise Enterprise-license / premium functionality labels Jun 26, 2023
@matifali
Copy link
Member

matifali commented Jun 26, 2023 •
edited
Loading

Hi @ericpaulsen,

We now support pushing templates as non-active so users will not be able to use the latest template version until a template admin or owner marks them as active using CLI or dashboard.

To push a template as nonactive they must use

coder template push <template-name> active=false

@MrPeacockNLB
Copy link
Contributor

To me this makes no sense to do it in Coder when using coder push. It make maybe sense to etablish this workflow if template edited only inside coder editor. But if one use coder push then the source code of the template relies somewhere and to me no one stores code not in a CVS like git today. When using git then there is also a CICD. If a company has to approve changes then they also uses CICD to implement approval of all code changes.

Just my 2 cents...

@matifali matifali mentioned this issue Jun 27, 2023
Closed
@ammario
Copy link
Member

ammario commented Jul 5, 2023

Why would modelling approve flows in Coder be superior to GitOps? It's a lot of complexity so the value would have to be significant.

@github-actions github-actions bot added the stale This issue is like stale bread. label Jan 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enterprise Enterprise-license / premium functionality stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ammario @ericpaulsen @matifali @MrPeacockNLB