Skip to content

Light theme #8396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bpmct opened this issue Jul 10, 2023 · 15 comments
Closed

Light theme #8396

bpmct opened this issue Jul 10, 2023 · 15 comments
Assignees
Labels
roadmap https://coder.com/roadmap. Only humans may set this.

Comments

@bpmct
Copy link
Member

bpmct commented Jul 10, 2023

Some users prefer to use a light mode!

@cdr-bot cdr-bot bot added the feature label Jul 10, 2023
@sharkymark
Copy link
Contributor

Light mode is the default to Coder v1 as well.

@alexander-dammeier
Copy link

Here in the EU/Germany there are currently some laws on the way that will force some areas to only use software with good accessibility. This includes for example high-contrast UIs, the usage of screen readers, keyboard-only navigation and the possibility to zoom up to 400%.
We are currently evaluating coder for some customers which will be affected by that and already have high standards for accessibility. Could you please keep that in mind while working on that? Currently i am not aware of how good coder already is with accessibility and of course coder also don't need to be perfect (i don't know any software that is) but that could make things way easier in the long term here.

@matifali
Copy link
Member

@matifali
Copy link
Member

cc: @aslilac as you were recently looking into this.

@aslilac aslilac self-assigned this Oct 28, 2023
@pasuder
Copy link

pasuder commented Dec 5, 2023

Following up on this 😃

@bpmct
Copy link
Member Author

bpmct commented Dec 5, 2023

We're actively working on a light theme! It should be out in the next 1-2 releases :)

@aslilac
Copy link
Member

aslilac commented Dec 5, 2023

Following up on this 😃

hi! specifically, I'm the one working on it. progress has just been a bit slow with holidays and some travel popping up lately, but we've got an early version that I'm currently working on polishing up.

@matifali matifali added the roadmap https://coder.com/roadmap. Only humans may set this. label Dec 18, 2023
@mattlqx
Copy link

mattlqx commented Dec 27, 2023

FYI, our logo in the upper-left basically disappears when using the Light theme.

@aslilac
Copy link
Member

aslilac commented Dec 29, 2023

yeah, issues with custom icons/logos are pretty much the main reason that it's marked as a "preview" instead of a stable feature. we're still trying to come up with a proper solution. if you have any ideas, I'd love to hear them!

@pasuder
Copy link

pasuder commented Jan 8, 2024

light dark theme

It does work very well (version v2.6.0+b3e3521), thank you @aslilac !

@aslilac
Copy link
Member

aslilac commented Jan 8, 2024

happy to hear it! feel free to share any issues you notice here. (icons have already been fixed, and will in the next release)

@ammario
Copy link
Member

ammario commented Apr 1, 2024

@aslilac what work remains to getting light theme out of "preview" mode and closing out this issue?

@aslilac
Copy link
Member

aslilac commented Apr 2, 2024

I haven't been hearing any bug reports about in lately, so maybe nothing?

@ammario ammario closed this as completed Apr 2, 2024
@mattlqx
Copy link

mattlqx commented Apr 2, 2024

Any solution to the white/black logo problem in that if your logo is either color it will disappear on that color theme?

@aslilac
Copy link
Member

aslilac commented Apr 2, 2024

it's a little magical and undocumented, by you can hint at how an image should be displayed by tweaking the url. if you set the url as something like https://cdn.example.com/logo.svg?monochrome we can tweak some things to try to make it look good on light and dark backgrounds.

there's also ?blackWithColor and ?whiteWithColor. there might be some places hiding that we don't apply those filters when we should, but most fields that accept a custom image url should respect those settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap https://coder.com/roadmap. Only humans may set this.
Projects
None yet
Development

No branches or pull requests

8 participants