Skip to content

Some metadata disappears from the UI for a long time, repeatedly #8577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mafredri opened this issue Jul 18, 2023 · 4 comments · Fixed by #8614
Closed

Some metadata disappears from the UI for a long time, repeatedly #8577

mafredri opened this issue Jul 18, 2023 · 4 comments · Fixed by #8614
Labels
s1 Bugs that break core workflows. Only humans may set this. site Area: frontend dashboard

Comments

@mafredri
Copy link
Member

mafredri commented Jul 18, 2023 •
edited
Loading

I don't know what's the cause, but using the Coder on Coder template on dev.coder.com, I'm seeing metadata appears for a short while, only to disappear again. This happens repeatedly.

Meanwhile, the VSCode extension is showing the values correctly.

Video:

Screen.Recording.2023-07-18.at.17.07.16.mov

Metadata appear at 0:58 and 3:58, so it seems to be on some interval. There might've been a redeploy/reconnect of dev.coder.com too somewhere around the 3-minute mark.
@mafredri mafredri added site Area: frontend dashboard bug labels Jul 18, 2023
@matifali
Copy link
Member

I am seeing the same behavior too.
In a different country, and on iPad. So it's not a device or network issue.
But we both do use the Europe region.

@matifali matifali added the s3 Bugs that confuse, annoy, or are purely cosmetic label Jul 18, 2023
@bpmct bpmct added s1 Bugs that break core workflows. Only humans may set this. and removed s3 Bugs that confuse, annoy, or are purely cosmetic labels Jul 19, 2023
@BrunoQuaresma
Copy link
Collaborator

BrunoQuaresma commented Jul 19, 2023 •
edited
Loading

One thing to look for is what data the web socket is sending. Sometimes I have seen the server sending null values making the loading state to be visible. I also noticed this happens during Coder deployments and when we have some instability(in the last two weeks I have been facing some timeouts when using yarn dev pointing to dev.coder.com, I thought it would be because of Coder deployments but they are very frequent).

We could make the FE just ignore null values but I would rather do the fix on the BE so other clients would not have to work around this.

@matifali
Copy link
Member

I have reproduced the issue on a deployment that follows the dev.coder.com version.
version: v0.26.1-devel+4232a2eb9

coadler added a commit that referenced this issue Jul 20, 2023
@coadler
fix(agent): check agent metadata every second instead of minute
d3b79c6 
I believe this is the fix for #8577.

When looking at the websocket, metadata keys go over 2 minutes without
updating, even when their interval is much lower. This fixes
`reportMetadataLoop` to run every second and properly calculate the
interval. A previous refactor set it to tick each minute instead of the
previous behavior of each second.
@coadler coadler mentioned this issue Jul 20, 2023
Merged
@matifali
Copy link
Member

matifali commented Aug 4, 2023

fixed by #8614

@matifali matifali closed this as completed Aug 4, 2023
@matifali matifali linked a pull request Aug 4, 2023 that will close this issue
fix(agent): check agent metadata every second instead of minute #8614
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s1 Bugs that break core workflows. Only humans may set this. site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(agent): check agent metadata every second instead of minute coder/coder
4 participants
@mafredri @BrunoQuaresma @matifali @bpmct