Skip to content

Add template version messages to the rest of the product #8657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 of 5 tasks
bpmct opened this issue Jul 21, 2023 · 7 comments · Fixed by #9708 or #9705
Closed
4 of 5 tasks

Add template version messages to the rest of the product #8657

bpmct opened this issue Jul 21, 2023 · 7 comments · Fixed by #9708 or #9705
Assignees
@aslilac
Labels
good first issue Easily solved issues suitable for starters and community contributors site Area: frontend dashboard

Comments

@bpmct
Copy link
Member

bpmct commented Jul 21, 2023 •
edited by aslilac
Loading

Background

You can set a template version message when publishing a new version, kind of like a git commit message.
Screenshot 2023-07-21 at 12 25 36 PM

To-do

We have template version messages, but they are not displayed everywhere yet.

  • Version picker
    Screenshot 2023-07-21 at 11 00 02 AM
  • VS Code extension
    Screenshot 2023-07-21 at 12 20 16 PM
  • Versions list in UI
    Screenshot 2023-07-21 at 12 21 15 PM
  • coder ssh 
     👋 Your workspace is outdated! Update it here: https://dev.coder.com/@bpmct/dev
  • On hover of Update button in UI :)

Anywhere else I'm missing?
@cdr-bot cdr-bot bot added the feature label Jul 21, 2023
@matifali matifali mentioned this issue Sep 1, 2023
Closed
@BrunoQuaresma BrunoQuaresma added site Area: frontend dashboard good first issue Easily solved issues suitable for starters and community contributors labels Sep 5, 2023
@aslilac
Copy link
Member

aslilac commented Sep 14, 2023 •
edited
Loading

It looks like the VSCode extension actually does support this: https://github.com/coder/vscode-coder/blob/3c668ebf4ee8d24b2615b54efa385d17444bdf3d/src/remote.ts#L313-L315

@matifali
Copy link
Member

matifali commented Sep 15, 2023 •
edited
Loading

Why, though, I have never seen this.

@aslilac aslilac mentioned this issue Sep 15, 2023
Merged
@aslilac
Copy link
Member

aslilac commented Sep 15, 2023

Do we actually care about coder ssh displaying the message if it links to a page which will have the message plastered all over it? Fine if the answer is yes, just curious. (See #9705 for a screenshot)

@aslilac aslilac mentioned this issue Sep 15, 2023
Merged
@aslilac
Copy link
Member

aslilac commented Sep 15, 2023

Why, though, I have never seen this.

Image

Ha, looks like it was added in the commit after the current release. We just need to publish a new version.

@aslilac
Copy link
Member

aslilac commented Sep 15, 2023

cc @code-asher

@code-asher
Copy link
Member

code-asher commented Sep 15, 2023 via email

@aslilac
Copy link
Member

aslilac commented Sep 16, 2023

Thank you!

This was linked to pull requests Sep 22, 2023
feat: show version messages in version lists #9708
Merged
feat: show update messages on workspace page #9705
Merged
@aslilac aslilac closed this as completed Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslilac aslilac

Labels
good first issue Easily solved issues suitable for starters and community contributors site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
5 participants
@aslilac @BrunoQuaresma @matifali @bpmct @code-asher