Skip to content

feature: List all enabled and available experiments on the deployment page #8978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 3 tasks
matifali opened this issue Aug 8, 2023 · 9 comments · Fixed by #8984 or #10276
Closed
2 of 3 tasks

feature: List all enabled and available experiments on the deployment page #8978

matifali opened this issue Aug 8, 2023 · 9 comments · Fixed by #8984 or #10276
Assignees
Labels
site Area: frontend dashboard

Comments

@matifali
Copy link
Member

matifali commented Aug 8, 2023

We already show enable experiments at deployments. https://dev.coder.com/api/v2/experiments
but it would be nice to list them on the deployment page.

This could be rendered as a list in the form of

  • deployment_health_page
  • moons
  • workspace_actions
  • single_tailnet
  • template_insights_page
  • deployment_health_page

Must have

  • List all enabled experiments on the deployment page

Nice to have

  • Additionally, list all available experiments
  • Use Human-friendly names for the experiments, e.g., deployment_health_page --> Deployment Health Page (you may ignore this one as we also need to tell the user the exact string to enable the experiment)
@matifali
Copy link
Member Author

matifali commented Aug 8, 2023

cc: @BrunoQuaresma @Emyrk @bpmct

@Emyrk
Copy link
Member

Emyrk commented Aug 8, 2023

I think we can just list the values like we do for other deployment value things. Making it very nice and designed is not necessary IMO.

95% of deployments will not use experiments, and the ones that do are inherently more technical for using them.

@Emyrk
Copy link
Member

Emyrk commented Aug 8, 2023

Reopen as it's a basic implementation. We can make it look nicer

@Emyrk Emyrk reopened this Aug 8, 2023
@matifali matifali changed the title featture: List all enabled and/or available experiments on the deployment page featture: List all enabled and available experiments on the deployment page Aug 8, 2023
@matifali
Copy link
Member Author

matifali commented Aug 9, 2023

@Emyrk I enabled all experiments on a PR deployment with CODER_EXPERIMENTS=*, but I do not see the Experiments field. Does it only appear when we enable individual experiments explicitly?

@Emyrk
Copy link
Member

Emyrk commented Aug 9, 2023

It should show, but to be honest I was not 100% sure how the typescript worked. Was just following the existing pattern.

Let me see...

@Emyrk
Copy link
Member

Emyrk commented Aug 9, 2023

Screenshot from 2023-08-09 09-53-33

Mine does show?

@bpmct
Copy link
Member

bpmct commented Aug 17, 2023

I'd love if we also linked to the experiments endpoint so the admin can see what can be enabled.

@bpmct bpmct added the site Area: frontend dashboard label Aug 17, 2023
@matifali matifali changed the title featture: List all enabled and available experiments on the deployment page feature: List all enabled and available experiments on the deployment page Aug 22, 2023
@matifali
Copy link
Member Author

@sharkymark I remember you were looking for a way to see all available experiments.

@Emyrk
Copy link
Member

Emyrk commented Oct 11, 2023

@bpmct @matifali Experiments are intentionally an "advanced" feature to opt into features that are not ready for production.

Do we really want to show these to everyone, meaning people might just "opt into" these experiments without understanding the repercussions?

Right now there is the concept of All which are safer:

coder/codersdk/deployment.go

Lines 2007 to 2014 in 9af5475

// ExperimentsAll should include all experiments that are safe for
// users to opt-in to via --experimental='*'.
// Experiments that are not ready for consumption by all users should
// not be included here and will be essentially hidden.
var ExperimentsAll = Experiments{
ExperimentDeploymentHealthPage,
ExperimentSingleTailnet,
}


Ya'lls call, just feels like a very niche feature to show all these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
4 participants