Skip to content

You must refresh the page to see the latest ports in "port forward" dialog #9135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpmct opened this issue Aug 16, 2023 · 2 comments · Fixed by #9221
Closed

You must refresh the page to see the latest ports in "port forward" dialog #9135

bpmct opened this issue Aug 16, 2023 · 2 comments · Fixed by #9221
Assignees
@BrunoQuaresma
Labels
must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this. s2 Broken use cases or features (with a workaround). Only humans may set this.

Comments

@bpmct
Copy link
Member

bpmct commented Aug 16, 2023

In old versions of Coder, you used to be able to click the port forward dialog and see newly opened ports. However, since Coder only requests ports once when the page loads, this is inaccurate if you do the following:

Current behavior

  1. Open workspace in web UI
  2. Start a server from the terminal: python3 -m http.server 3000
  3. Notice the port count did not increase
  4. Notice that when you click the dialog port 3000 appears
  5. Refresh the page to see the new port
Screen.Recording.2023-08-16.at.12.48.23.PM.mov

Desired behavior

It constantly has accurate port info without a refresh
@bpmct bpmct added s2 Broken use cases or features (with a workaround). Only humans may set this. bug labels Aug 16, 2023
@matifali
Copy link
Member

related to #8834

@bpmct bpmct mentioned this issue Aug 17, 2023
Closed
@BrunoQuaresma
Copy link
Collaborator

BrunoQuaresma commented Aug 17, 2023 •
edited
Loading

Ahhhhh now it makes way easier to understand. What we can do to make the ports update automatically is:

  • Pulling the ports
  • Have a WS or Server Events for the ports endpoint (IMO it is the best way)

I would need some BE help to get this working. cc: @mafredri @mtojek

@ammario ammario added the must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this. label Aug 18, 2023
@BrunoQuaresma BrunoQuaresma mentioned this issue Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
must-do Issues that must be completed by the end of the Sprint. Or else. Only humans may set this. s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(site): fix ports update coder/coder
4 participants
@BrunoQuaresma @ammario @matifali @bpmct