-
Notifications
You must be signed in to change notification settings - Fork 887
Publishing a template in UI does return to the template UI and should provide a confirmation #9243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I see more than one thing here: Bugs
Feature
|
This was done as a part of #9153, which responded to an issue (#7153) that I originally proposed to Bruno. When someone is rapidly iterating on a template, it can be frusterating if you get constantly redirected if you want to stay in the editor. However, I can see how it is equally frusterating if there isn't a clear confirmation your new version was published or maybe there are cases where they want to back to the template UI. Without a clear "you have saved this version" dialog, I can see how this would come across as a regression. One suggestion is to add a dialog:
This wording isn't perfect, but may help with the confusion. Alternatively, we could revert the PR and always redirect. Will defer to @BrunoQuaresma and @aslilac here :) |
I saw @aslilac also suggested a "publish and keep editing" option. I'd be open to something like this in the dropdown as a secondary option |
You can still do this navigation by clicking on the name of the template while in the editor, but we might want to make that more noticeable somehow. |
Version:
v2.0.0+ad513fa
As an operator (e.g., owner or template admin), if I
Build
and thenPublish
a template in the Coder dashboard UI, there is no confirmation message nor does the UI revert to the template dashboard UI view like in previous releases.This is a regression. I was able to return the template dashboard UI in release in
2.0.0
If you click
Publish
again it shows the same version name but should have a new name generated.With previous releases and this release, the
Build
button shows available and a greenSuccess
label next to it, but we should consider graying out theBuild
button if there are no pending template changes, to signal to the user thatPublish
is the only action available.@BrunoQuaresma
The text was updated successfully, but these errors were encountered: