Skip to content

Publishing a template in UI does return to the template UI and should provide a confirmation #9243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sharkymark opened this issue Aug 22, 2023 · 4 comments · Fixed by #9346
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this. site Area: frontend dashboard

Comments

@sharkymark
Copy link
Contributor

sharkymark commented Aug 22, 2023

Version: v2.0.0+ad513fa

As an operator (e.g., owner or template admin), if I Build and then Publish a template in the Coder dashboard UI, there is no confirmation message nor does the UI revert to the template dashboard UI view like in previous releases.

This is a regression. I was able to return the template dashboard UI in release in 2.0.0

If you click Publish again it shows the same version name but should have a new name generated.

With previous releases and this release, the Build button shows available and a green Success label next to it, but we should consider graying out the Build button if there are no pending template changes, to signal to the user that Publish is the only action available.

@BrunoQuaresma

Front logo Front conversations

@sharkymark sharkymark added the bug label Aug 22, 2023
@sharkymark sharkymark changed the title Publishing a template in UI does not provide a confirmation Publishing a template in UI does return to the template UI and should provide a confirmation Aug 22, 2023
@BrunoQuaresma BrunoQuaresma added feature site Area: frontend dashboard labels Aug 22, 2023
@BrunoQuaresma
Copy link
Collaborator

I see more than one thing here:

Bugs

  • Not redirecting to the template UI after publish
  • The new version name in the modal is not correct. It is using the previous one

Feature

  • Disable the build button if there are no changes to apply

@bpmct
Copy link
Member

bpmct commented Aug 22, 2023

This was done as a part of #9153, which responded to an issue (#7153) that I originally proposed to Bruno. When someone is rapidly iterating on a template, it can be frusterating if you get constantly redirected if you want to stay in the editor. However, I can see how it is equally frusterating if there isn't a clear confirmation your new version was published or maybe there are cases where they want to back to the template UI. Without a clear "you have saved this version" dialog, I can see how this would come across as a regression.

One suggestion is to add a dialog:

The version rapid-carrot has been published. The version [is/is not] promoted to all users.
[CTA: Create workspace from version (to test your changes)?]

This wording isn't perfect, but may help with the confusion. Alternatively, we could revert the PR and always redirect. Will defer to @BrunoQuaresma and @aslilac here :)

@bpmct
Copy link
Member

bpmct commented Aug 22, 2023

I saw @aslilac also suggested a "publish and keep editing" option. I'd be open to something like this in the dropdown as a secondary option

@aslilac
Copy link
Member

aslilac commented Aug 22, 2023

I was able to return the template dashboard UI

You can still do this navigation by clicking on the name of the template while in the editor, but we might want to make that more noticeable somehow.

@bpmct bpmct added the s2 Broken use cases or features (with a workaround). Only humans may set this. label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this. site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants