Skip to content

test flake TestWorkspace/Rename #9400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Aug 29, 2023 · 0 comments · Fixed by #9402
Closed

test flake TestWorkspace/Rename #9400

spikecurtis opened this issue Aug 29, 2023 · 0 comments · Fixed by #9402
Assignees
@mafredri

Comments

@spikecurtis
Copy link
Contributor 

    workspaces_test.go:122:
                Error Trace:    /home/coder/coder/coderd/workspaces_test.go:122
                Error:          Received unexpected error:
                                PATCH http://localhost:34725/api/v2/workspaces/bc9c9776-f28d-4f11-8c1f-964f89d101d9: unexpected status code 400: Validation failed.
                                        name: Validation failed for tag "username" with value: "affectionate-varahamihira0--test"
                Test:           TestWorkspace/Rename
                Messages:       workspace rename failed

Our "username" regex, which also applies to workspace names, doesn't allow two dashes in a row. That might be a bug? But, maybe we use two dashes as a special sequence in DevURLs?

Anyway, when the workspace name is too long, we trim it down, but sometimes the trimming can leave a - at the end, which we then add -test to, and validation fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(coderd): fix workspace rename test coder/coder
2 participants
@mafredri @spikecurtis