I agree. WAU is a better indication of usage. If we go with this, our default views will change. The X-axis becomes weeks and we should show at least previous ten weeks. Currently, we are only showing data from the last 30 days.

In the design and FE part, this is not very challenging but it can be for the BE. cc.: @mafredri

We currently support interval=day, I think this should be quite easily implemented by adding a new interval=week parameter. The query just needs to switch from 1 day to 7 day intervals when this parameter changes. The dashboard can then decide which type of request to make.

I would suggest making the interval selection automatic based on the selected time range, not template creation. There is, however, a question of how to represent/request the data when the user has selected 2 weeks + 2 days, this may be an inherent problem with "intelligent" selection of interval.

I think when the interval is set to week, a user should only be allowed to select increments of 7 days.

I'm working on this now 👍

I think when the interval is set to week, a user should only be allowed to select increments of 7 days.

I agree, it could be caught as a simple precondition at request validation.

In the design and FE part, this is not very challenging but it can be for the BE. cc.: @mafredri

@BrunoQuaresma interval=week got merged now. Would you mind adjusting the FE side?

To accommodate this I see the following tasks that can take quite long:

• Since this weekly control is only related to the active users, we have to move the "date range control" to be specific to each chart.
• Do we want to keep the "date range picker"? If the user selects an interval of 30 days for example, what should we do? I have some ideas but any of them look very good:
  • Change the interval to daily but it can be unexpected to the user
  • If the number of days is multiple of 7 we can change the interval to weekly but again, it can be unpredictable to the user
• How do we want to display the labels? Right now we display the day number but there is no standard for weeks. Maybe we could use "1 - 8" but I think it can consume too much horizontal space.
• What is the default number of weeks?
• What are going to be the presets for weekly values? Eg. Last 4 weeks, Last 2 weeks, etc.

@BrunoQuaresma

1. I suggest we remove the date range picker and provide a default view of the last 10 weeks
2. We show options to see
   • Last 10 weeks (default)
   • Last 3 months (12 weeks, so close to 10 weeks)
   • Last 6 months
3. For labels show the start date of each week (it could be Monday or just the start day of our aggregated data of that week). For example, if a user is seeing this on a Thursday, all dates shown on the x-axis will be of previous Thursdays.

@matifali

For labels show the start date of each week (it could be Monday or just the start day of our aggregated data of that week). For example, if a user is seeing this on a Thursday, all dates shown on the x-axis will be of previous Thursdays.

If it is not the previous Thursday, what should be displayed?

@BrunoQuaresma, I do not understand. It may also depend on how the stats are aggregated.

1. If they are being fetched from db already aggregated for each week starting Monday, then we should display the date of each Monday.
2. If they are being aggregated at runtime as the user navigates the page and aggregation is performed relative to today, then we should display the start date of each aggregation period (each week)

If they are being fetched from db already aggregated for each week starting Monday, then we should display the date of each Monday.

wondering if it would not make the user think it is about that day specifically

We could show Monday for the axis and Monday - Sunday on hover?

Idk, having multiple Mondays on the x-axis sounds... confusing. Something like "1 - 8" would not be better? Wondering which other apps aggregate data like this so we could use them as reference.

@BrunoQuaresma We are not showing the date we show the date on that day
So in case we show the date of each Monday
or I suggested before the date of each Thursdays

I'm very confused about this haha. Can you please mock something on Figma or any other image editor to show me how you are visualizing this? I think it will be just easier this way

To be honest, for me the most logical thing would be to display the start date on the graph axis. E.g. if it's last weeks Monday to this Monday, we'd show 18.9 on the axis. And on hover we can optionally show weekdays (Monday - Sunday), but we'd at least show 18.9 - 24.9, or 18.9 00:00 - 25.9 00:00 if we want to be precise (in the short form we count the end date as inclusive, hence 24 vs 25).

@BrunoQuaresma something like

@BrunoQuaresma posted this on slack:

PS: When adding weekly interval to the insights page, it is taking around 50 seconds ~70 seconds to display the data.

I'm going to take a look at this today.

@BrunoQuaresma I did a bit of QA work around this implementation, and found following problems:

1. When I select 48 weeks, Coder UI dies.

2. There is no point in showing the period > 6 months. We prune stats older than 6 months. Look at the horizontal line showing zero usage until August. Note: I know Oct - Aug = 4 months, but the cleanup deadline was 3 months before we changed it.