Skip to content

test flake: TestTemplateInsights_Golden/multiple_users_and_workspaces #9772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Sep 19, 2023 · 2 comments · Fixed by #9778
Closed

test flake: TestTemplateInsights_Golden/multiple_users_and_workspaces #9772

spikecurtis opened this issue Sep 19, 2023 · 2 comments · Fixed by #9778
Assignees
@spikecurtis
Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks

Comments

@spikecurtis
Copy link
Contributor

Seems to be failing because of a dropped error log:

t.go:90: 2023-09-19 11:50:02.980 [erro]  batchstats: error inserting workspace agent stats  error="context canceled"  elapsed=2.955782ms

https://github.com/coder/coder/actions/runs/6235120273/job/16923682461?pr=9765
@spikecurtis spikecurtis self-assigned this Sep 19, 2023
@cdr-bot cdr-bot bot added the chore label Sep 19, 2023
@spikecurtis
Copy link
Contributor Author

Also:

t.go:90: 2023-09-19 12:06:14.481 [erro]  batchstats: error inserting workspace agent stats  error="pq: canceling statement due to user request"  elapsed=17.569848ms

@matifali matifali added bug s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks labels Sep 19, 2023
@mafredri
Copy link
Member

mafredri commented Sep 19, 2023 •
edited
Loading

I kept running into the first issue so many times I fixed it in: #9777 (looked up this issue afterwards), however, we may require additional handling for the pq error.

@mafredri mafredri mentioned this issue Sep 19, 2023
Merged
mafredri added a commit that referenced this issue Sep 19, 2023
@mafredri
fix(coderd/batchstats): use debug log on query cancellation in flush
4d9ddc6 
Fixes #9772
mafredri added a commit that referenced this issue Sep 19, 2023
@mafredri
fix(coderd/batchstats): use debug log on query cancellation in flush (#…
161a3cf 
…9778)

Fixes #9772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spikecurtis spikecurtis

Labels
s4 Internal bugs (e.g. test flakes), extreme edge cases, and bug risks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(coderd/batchstats): use debug log on query cancellation in flush coder/coder
3 participants
@mafredri @spikecurtis @matifali