Skip to content

Audit logs: IP is missing/nil for workspace_build events #9867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
denbeigh2000 opened this issue Sep 25, 2023 · 3 comments · Fixed by #10242
Closed

Audit logs: IP is missing/nil for workspace_build events #9867

denbeigh2000 opened this issue Sep 25, 2023 · 3 comments · Fixed by #10242
Assignees
@coadler
Labels
s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@denbeigh2000
Copy link
Contributor

Currently, in audit log entries for workspace_build events, <nil> is currently set for Ip values, when it should contain the IP the request came from.

Here is a sample of what is currently seen:
Screenshot_2023-09-25_at_13 58 03

Instead of <nil>, I would expect this field to contain the IP address of the actor that invoked the action.

Observed on v2.1.5+66019ef.
@cdr-bot cdr-bot bot added the bug label Sep 25, 2023
@kylecarbs
Copy link
Member

We shall fix this. Thank you @denbeigh2000!

@Emyrk
Copy link
Member

Emyrk commented Sep 28, 2023

This is going to require adding the IP meta data to the job

@Emyrk
Copy link
Member

Emyrk commented Sep 28, 2023

@coadler would using TraceMetadata not be the move here?

It seems to be for OTEL tracing: https://github.com/coder/coder/blob/ff73baba92904f631f05d07cfb64fb5826a90698/coderd/tracing/util.go#L47-L56

But since it's used to track the request cycle, it would be nice if we could extend the context for some coder specific tracing props.

@matifali matifali added the s3 Bugs that confuse, annoy, or are purely cosmetic label Oct 2, 2023
@coadler coadler mentioned this issue Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coadler coadler

Labels
s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add requester IP to workspace build audit logs coder/coder
5 participants
@denbeigh2000 @Emyrk @coadler @kylecarbs @matifali