Skip to content

add a Full Name to accounts page #9883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
matifali opened this issue Sep 27, 2023 · 3 comments · Fixed by #11683
Closed
3 tasks done

add a Full Name to accounts page #9883

matifali opened this issue Sep 27, 2023 · 3 comments · Fixed by #11683
Assignees
Labels
good first issue Easily solved issues suitable for starters and community contributors site Area: frontend dashboard

Comments

@matifali
Copy link
Member

matifali commented Sep 27, 2023

Context

Currently, we only have Username and Email, I would like also to have name that can be set to any name by the user. For example, I want to set it to "Muhammad Atif Ali" and be accessed via data.coder_workspace.me.owner_name

image

ToDo

Motivation

This will allow us to set the full name of the developers as the user.name property for our git-config module. e.g., git config user.name "${data.coder_workspace.me.owner_name}"

cc: @kylecarbs, @bpmct and @ammario for comments

@ammario
Copy link
Member

ammario commented Sep 27, 2023

👍🏽 seems logical to me.

@sreya sreya added the site Area: frontend dashboard label Oct 2, 2023
@matifali matifali added the good first issue Easily solved issues suitable for starters and community contributors label Dec 4, 2023
@mtojek mtojek assigned mafredri and mtojek and unassigned mafredri Jan 8, 2024
@johnstcn
Copy link
Member

Note: I wouldn't bother breaking up the first name / last name fields in the UI.
See: https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/

@mtojek
Copy link
Member

mtojek commented Jan 17, 2024

Yup, a single name field instead will be safer 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Easily solved issues suitable for starters and community contributors site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants