Skip to content

chore: rename AwaitTemplateVersionJobCompleted and AwaitWorkspaceBuildJobCompleted #10003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2023
Merged

chore: rename AwaitTemplateVersionJobCompleted and AwaitWorkspaceBuildJobCompleted #10003

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2448ab3
chore: rename `AwaitTemplateVersionJobCompleted` and `AwaitWorkspaceB…
aslilac Oct 2, 2023
e8b84eb
for real tho
aslilac Oct 2, 2023
7d8d1fe
Merge branch 'main' into AwaitTemplateVersionJobCompleted
aslilac Oct 3, 2023
a29f84d
fix comment name
aslilac Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: rename AwaitTemplateVersionJobCompleted and `AwaitWorkspaceB… 
…uildJobCompleted`
  • Loading branch information
@aslilac
aslilac committed Oct 2, 2023
commit 2448ab3cda4eb94ba88948d262d2f6e2d96bbb62
8 changes: 4 additions & 4 deletions coderd/coderdtest/coderdtest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,8 +760,8 @@ func UpdateTemplateVersion(t *testing.T, client *codersdk.Client, organizationID
return templateVersion
}

// AwaitTemplateImportJob awaits for an import job to reach completed status.
func AwaitTemplateVersionJob(t *testing.T, client *codersdk.Client, version uuid.UUID) codersdk.TemplateVersion {
// AwaitTemplateImportJobCompleted awaits for an import job to reach completed status.
func AwaitTemplateVersionJobCompleted(t *testing.T, client *codersdk.Client, version uuid.UUID) codersdk.TemplateVersion {
t.Helper()

ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
Expand All @@ -778,8 +778,8 @@ func AwaitTemplateVersionJob(t *testing.T, client *codersdk.Client, version uuid
return templateVersion
}

// AwaitWorkspaceBuildJob waits for a workspace provision job to reach completed status.
func AwaitWorkspaceBuildJob(t *testing.T, client *codersdk.Client, build uuid.UUID) codersdk.WorkspaceBuild {
// AwaitWorkspaceBuildJobCompleted waits for a workspace provision job to reach completed status.
func AwaitWorkspaceBuildJobCompleted(t *testing.T, client *codersdk.Client, build uuid.UUID) codersdk.WorkspaceBuild {
t.Helper()

ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort)
Expand Down