fix: GitSSH test flake on slow CI runs #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a 5s timeout on the context, which was occasionally hit during slow runs. See: https://github.com/coder/coder/runs/6025622326?check_suite_focus=true I also removed the AWS authentication, because it added to the test time for key-generation and such.
Codecov Report
@@ Coverage Diff @@
## main #1001 +/- ##
========================================
Coverage 66.62% 66.62%
========================================
Files 249 252 +3
Lines 14686 14870 +184
Branches 135 135
========================================
+ Hits 9784 9907 +123
- Misses 3923 3963 +40
- Partials 979 1000 +21
Continue to review full report at Codecov.
|
f0ssel
approved these changes
Apr 14, 2022
|
I tried basic token and failed for some reason, so I just copied the other test code. Welcoming this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a 5s timeout on the context, which was occasionally
hit during slow runs. See:
https://github.com/coder/coder/runs/6025622326?check_suite_focus=true
I also removed the AWS authentication, because it added to the test
time for key-generation and such.