interval reports can be omitted too

coder · mtojek · Oct 3, 2023 · Oct 3, 2023 · Oct 3, 2023 · Oct 3, 2023
commit b29553726adb227eb7c9eb9b3e862164e32f0c96
diff --git a/...emplate/multiple_users_and_workspaces_three_weeks_second_template_only_report.json.golden b/...emplate/multiple_users_and_workspaces_three_weeks_second_template_only_report.json.golden
@@ -59,6 +59,5 @@
       }
     ],
     "parameters_usage": []
-  },
-  "interval_reports": []
+  }
 }
diff --git a/coderd/testdata/insights/template/parameters_two_days_ago,_no_data.json.golden b/coderd/testdata/insights/template/parameters_two_days_ago,_no_data.json.golden
@@ -39,6 +39,5 @@
       }
     ],
     "parameters_usage": []
-  },
-  "interval_reports": []
+  }
 }
diff --git a/coderd/testdata/insights/template/parameters_yesterday_and_today_deployment_wide.json.golden b/coderd/testdata/insights/template/parameters_yesterday_and_today_deployment_wide.json.golden
@@ -160,6 +160,5 @@
         ]
       }
     ]
-  },
-  "interval_reports": []
+  }
 }
diff --git a/codersdk/insights.go b/codersdk/insights.go
@@ -186,7 +186,7 @@ func (c *Client) UserActivityInsights(ctx context.Context, req UserActivityInsig
 // TemplateInsightsResponse is the response from the template insights endpoint.
 type TemplateInsightsResponse struct {
 	Report          *TemplateInsightsReport          `json:"report,omitempty"`
-	IntervalReports []TemplateInsightsIntervalReport `json:"interval_reports"`
+	IntervalReports []TemplateInsightsIntervalReport `json:"interval_reports,omitempty"`
 }
 
 // TemplateInsightsReport is the report from the template insights endpoint.

diff --git a/site/src/api/typesGenerated.ts b/site/src/api/typesGenerated.ts
@@ -589,12 +589,12 @@ function mapToDAUsResponse(
 ): DAUsResponse {
   return {
     tz_hour_offset: 0,
-    entries: data.map((d) => {
+    entries: data ? data.map((d) => {
       return {
         amount: d.active_users,
         date: d.start_time,
       };
-    }),
+    }) : [],
   };
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -59,6 +59,5 @@ @@
           }
         ],
         "parameters_usage": []
-      },
-      "interval_reports": []
+      }
     }