I don't like checking just data for loading. we do this in a lot of places, and it ends up with lots of places that show spinners instead of error messages.

I usually handle errors when they are expected like form errors, or possible user actions that can cause an "invalid" state. IMO handling all the errors caused by async can be too much and idk if that adds too much value, to be honest, but I'm open to that.

Maybe could be interesting to start a thread on dev about handling errors in the UI and see if we can come up with a more solid strategy.

I'm also going to put some thoughts on that 🤔. Can we get this work merged and I open the PR to handle the error for all the Insights pages?

fair enough

Is there anything else I should do to get your quality approval? 👀

Not going to treat this as a blocking comment, but does the whole data need to be made a prop, or would it be safe just to have the component receive the users, since that's the only part the component seems like it would ever care about?

Yes, it could but since its goal is to display the UserActivityInsightsResponse data I think it is ok to use it.

I think it is just easier to maintain and extend using the context object than passing prop by prop.

Not going to treat this as a blocking comment, but does the whole data need to be made a prop, or would it be safe just to have the component receive the users, since that's the only part the component seems like it would ever care about?