Skip to content

feat: add image pre-loading hooks #10015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

feat: add image pre-loading hooks #10015

wants to merge 5 commits into from

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Oct 3, 2023

This PR makes image pre-loading available to all React components, either passively or as an active function that can be attached to event handlers.

Aiming to have this done by the end of the week, but it's being treated as lower-priority, since it's mainly provides visual enhancements, rather than critical functionality or bug fixes

Left to do

  • Flesh out tests for the hooks

@Parkreiner
Copy link
Member Author

Forgot to post this earlier, but I'm going to park this PR for a little bit longer. I think the hooks themselves have the right APIs, but the functionality under the hood needs to be a lot more involved than I thought it'd be, especially when multiple components are making requests for similar images

@github-actions github-actions bot added the stale This issue is like stale bread. label Oct 13, 2023
@github-actions github-actions bot closed this Oct 16, 2023
@github-actions github-actions bot deleted the mes/pre-loading branch April 5, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale This issue is like stale bread.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant