fix: Agent/SessionTTY flake waiting for terminal prompt #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For an unknown reason, the prompt wouldn't appear on Windows randomly in CI. This shouldn't be a necessary check anyways, because terminal input will be buffered.
johnstcn
approved these changes
Apr 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #1002 +/- ##
===========================================
- Coverage 66.62% 56.55% -10.07%
===========================================
Files 249 132 -117
Lines 14686 13391 -1295
Branches 135 0 -135
===========================================
- Hits 9784 7573 -2211
- Misses 3923 4936 +1013
+ Partials 979 882 -97
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an unknown reason, the prompt wouldn't appear on Windows
randomly in CI. This shouldn't be a necessary check anyways,
because terminal input will be buffered.