Skip to content

chore: compute job status as column #10024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Oct 5, 2023
Merged

chore: compute job status as column #10024

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7736647
chore: provisioner job status as column
Emyrk Oct 3, 2023
16e17e8
use provisioner job status for workspace searching
Emyrk Oct 3, 2023
a5d8268
Linting
Emyrk Oct 3, 2023
9e20024
Remove intervals
Emyrk Oct 3, 2023
f21d58c
make gen
Emyrk Oct 3, 2023
60dd8df
Fix unit tests
Emyrk Oct 3, 2023
113bcb2
Handle unknown status
Emyrk Oct 3, 2023
2ddb544
Fix unit test job tags
Emyrk Oct 3, 2023
afed3b6
Fix typo
Emyrk Oct 3, 2023
5c3c359
Make gen
Emyrk Oct 3, 2023
7e879f9
remove debug print
Emyrk Oct 3, 2023
d028ed1
sql spacing
Emyrk Oct 3, 2023
4cc1822
Fix sql comparisons
Emyrk Oct 3, 2023
e4c1c7d
Fix sqlc arg
Emyrk Oct 3, 2023
55e266a
Make gen
Emyrk Oct 3, 2023
10a4a96
Workspace build status is flakey, need to rewrite test
Emyrk Oct 4, 2023
ae31c77
Merge remote-tracking branch 'origin/main' into stevenmasley/computed…
Emyrk Oct 4, 2023
191ee82
Put back test, fix running state
Emyrk Oct 4, 2023
97d32a3
make gen
Emyrk Oct 4, 2023
05ca60e
Fix spacing
Emyrk Oct 4, 2023
b378708
Make gen
Emyrk Oct 4, 2023
a95b702
Fix build
Emyrk Oct 4, 2023
9ce0fa6
Merge issue broke test
Emyrk Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sql spacing
  • Loading branch information
@Emyrk
Emyrk committed Oct 3, 2023
commit d028ed1f5206eac8cccbed86f32c9ea014c711e4
46 changes: 23 additions & 23 deletions coderd/database/migrations/000160_provisioner_job_status.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,31 +6,31 @@ COMMENT ON TYPE provisioner_job_status IS 'Computed status of a provisioner job.
ALTER TABLE provisioner_jobs ADD COLUMN
job_status provisioner_job_status NOT NULL GENERATED ALWAYS AS (
CASE
-- Completed means it is not in an "-ing" state
WHEN completed_at IS NOT NULL THEN
CASE
-- The order of these checks are important.
-- Check the error first, then cancelled, then completed.
WHEN error != '' THEN 'failed'::provisioner_job_status
WHEN canceled_at IS NOT NULL THEN 'canceled'::provisioner_job_status
ELSE 'succeeded'::provisioner_job_status
END
-- Completed means it is not in an "-ing" state
WHEN completed_at IS NOT NULL THEN
CASE
-- The order of these checks are important.
-- Check the error first, then cancelled, then completed.
WHEN error != '' THEN 'failed'::provisioner_job_status
WHEN canceled_at IS NOT NULL THEN 'canceled'::provisioner_job_status
ELSE 'succeeded'::provisioner_job_status
END
-- Not completed means it is in some "-ing" state
ELSE
CASE
-- This should never happen because all errors set
-- should also set a completed_at timestamp.
-- But if there is an error, we should always return
-- a failed state.
WHEN error != '' THEN 'failed'::provisioner_job_status
WHEN canceled_at IS NOT NULL THEN 'canceling'::provisioner_job_status
-- Not done and not started means it is pending
WHEN started_at IS NULL THEN 'pending'::provisioner_job_status
ELSE 'running'::provisioner_job_status
END
END
ELSE
CASE
-- This should never happen because all errors set
-- should also set a completed_at timestamp.
-- But if there is an error, we should always return
-- a failed state.
WHEN error != '' THEN 'failed'::provisioner_job_status
WHEN canceled_at IS NOT NULL THEN 'canceling'::provisioner_job_status
-- Not done and not started means it is pending
WHEN started_at IS NULL THEN 'pending'::provisioner_job_status
ELSE 'running'::provisioner_job_status
END
END
-- Stored so we do not have to recompute it every time.
) STORED;
) STORED;


COMMENT ON COLUMN provisioner_jobs.job_status IS 'Computed column to track the status of the job.';
Expand Down