Skip to content

chore: use emotion for styling (pt. 3) #10026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 5, 2023
Merged

chore: use emotion for styling (pt. 3) #10026

merged 16 commits into from
Oct 5, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Oct 3, 2023

Part of #9924
Following #9951

Progress 21_6

From starting with 157 usages of makeStyles across 154 files, this changes brings us down to 123 usages across 120 files.

This time I specifically targeted usage of makeStyles that used "props", since I thought they might be tricky, and good to think about early. They were actually all pretty straight forward!

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the stories are good, I'm good!

@aslilac aslilac merged commit 246dae0 into main Oct 5, 2023
@aslilac aslilac deleted the emotional-damage-3 branch October 5, 2023 16:49
@aslilac aslilac linked an issue Oct 5, 2023 that may be closed by this pull request
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace makeStyles
2 participants