Skip to content

fix(coderd): fetch workspace agent scripts and log sources using system auth ctx #10043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2023
Merged

fix(coderd): fetch workspace agent scripts and log sources using system auth ctx #10043

merged 2 commits into from
Oct 4, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Oct 4, 2023 •
edited
Loading

Bandages #10037 but probably wants a follow-up PR for innoculation.

  • Adds a unit test to ensure that a regular member can fetch a workspace agent
  • Modfies the /workspaceagents/{agentid} endpoint to use system authz context when fetching agent scripts and log sources

@johnstcn johnstcn self-assigned this Oct 4, 2023
mafredri
mafredri approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch & fix!

Agree with the TODO, would be nice.

@johnstcn johnstcn added the hotfix label Oct 4, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Oct 4, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@johnstcn johnstcn merged commit 2c2e98c into main Oct 4, 2023
@johnstcn johnstcn deleted the cj/member-cannot-port-forward branch October 4, 2023 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mafredri