ci: remove building from test/js #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1005 +/- ##
==========================================
- Coverage 66.90% 66.71% -0.19%
==========================================
Files 253 250 -3
Lines 14941 14757 -184
Branches 135 135
==========================================
- Hits 9996 9845 -151
+ Misses 3950 3930 -20
+ Partials 995 982 -13
Continue to review full report at Codecov.
|
kylecarbs
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There's no reason to build in
test/js, since we have e2e tests that build.Details:
yarn buildfromtest/jsstep in CIRelates to #1004 but does not fix it.