Skip to content

feat: show descriptions for parameter options #10068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 5, 2023
Merged

feat: show descriptions for parameter options #10068

merged 9 commits into from
Oct 5, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Oct 4, 2023 •
edited
Loading

Closes #8707

Screenshot 2023-10-04 at 4 52 39 PM

Small version design is still a bit WIP

@aslilac aslilac requested a review from BrunoQuaresma October 4, 2023 22:55
BrunoQuaresma
BrunoQuaresma approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, there are just a few lint warnings and storybook checks to be reviewed. 👍

@aslilac aslilac merged commit 3c87c4d into main Oct 5, 2023
@aslilac aslilac deleted the parameter-descriptions branch October 5, 2023 19:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template Option Description Not Visible
2 participants
@aslilac @BrunoQuaresma