Skip to content

chore: use workspace name as arg in coder workspaces create #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 14, 2022
Merged

chore: use workspace name as arg in coder workspaces create #1007

merged 4 commits into from
Apr 14, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Apr 14, 2022

Fixes #1003

@coadler coadler requested a review from kylecarbs April 14, 2022 16:34
@coadler coadler self-assigned this Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022 •
edited
Loading

Codecov Report

Merging #1007 (35eac1f) into main (7090227) will decrease coverage by 0.48%.
The diff coverage is 58.82%.

@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
- Coverage   67.01%   66.52%   -0.49%     
==========================================
  Files         253      250       -3     
  Lines       14941    14759     -182     
  Branches      135      135              
==========================================
- Hits        10013     9819     -194     
- Misses       3938     3952      +14     
+ Partials      990      988       -2
Flag Coverage Δ
unittest-go-macos-latest 53.54% <58.82%> (-0.04%) ⬇️
unittest-go-postgres- 66.50% <58.82%> (-0.33%) ⬇️
unittest-go-ubuntu-latest 56.15% <58.82%> (-0.03%) ⬇️
unittest-go-windows-2022 ?
unittest-js 61.61% <ø> (ø)
Impacted Files Coverage Δ
cli/templatecreate.go 46.92% <57.14%> (-0.51%) ⬇️
cli/workspacecreate.go 56.66% <59.25%> (+1.40%) ⬆️
cli/configssh.go 61.41% <0.00%> (-7.09%) ⬇️
coderd/parameter/compute.go 74.07% <0.00%> (-6.67%) ⬇️
coderd/httpapi/httpapi.go 66.25% <0.00%> (-6.25%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
pty/ptytest/ptytest.go 89.65% <0.00%> (-5.18%) ⬇️
coderd/provisionerdaemons.go 60.89% <0.00%> (-3.61%) ⬇️
coderd/workspaceagents.go 59.82% <0.00%> (-3.58%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7090227...35eac1f. Read the comment docs.

@coadler coadler enabled auto-merge (squash) April 14, 2022 16:51
@coadler coadler force-pushed the colin/workspace-create-name branch from 1905d33 to 35eac1f Compare April 14, 2022 17:09
@coadler coadler merged commit f803e37 into main Apr 14, 2022
@coadler coadler deleted the colin/workspace-create-name branch April 14, 2022 17:23
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

Revert coder workspaces create to accept workspace name instead of template name
3 participants
@coadler @kylecarbs @misskniss