-
Notifications
You must be signed in to change notification settings - Fork 985
feat: make the dashboard darker #10084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coder is a the internal software development platform. It is not designed to be opinionated on colors, but it should look great. Focusing on neutrality for our default dashboard theme is great for our ICP. Some organizations may lean towards colors more or less, and that shouldn't influence their decision when exploring Coder.
So I was a fan of the blue palette. It seemed to strike a good balance between being different, while looking restrained, since blue is generally treated as a more traditional color. Muting the non-interactive colors further does have some benefits, though. It makes the elements that still have color pop out, because they're working more like true highlight colors. That can help give us more ways of emphasizing important elements I'd be a little sad to see the blue go away, but I feel like it might give us more room overall for using color for functional purposes |
I also feel like we might not need to kill the color entirely, and just "condense" the color ranges. GitHub's palette reads as pretty neutral to me, but even their darkest backgrounds are still blue-tinged |
3: "hsl(218, 44%, 92%)", | ||
2: "hsl(220, 50%, 95%)", | ||
1: "hsl(220, 55%, 98%)", | ||
17: "hsl(0, 0%, 1%)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to the actual PR, but is there a reason why we have so many color stops? I think the most I've ever seen is 10–12 (usually mapping to the font weight system of 100-900, with maybe a 50 and a 950 thrown in)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this is debt. We should reduce these in the future.
@Parkreiner it's not that I wasn't a fan of the blue, I just think this darker palette is a better base for us to build on. We can slightly tinge things blue as well, I'm fine with that, I just want something more base-dark for us to iterate on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If storybook is good, I'm good 👍
🚀 Deploying PR 10084 ... |
Coder is the internal software development platform. It is not designed to be opinionated on colors, but it should look great.
Focusing on neutrality for our default dashboard theme is great for our ICP. Some organizations may lean towards colors more or less, and that shouldn't influence their decision when exploring Coder.
Before:

After:
