Skip to content

chore: add icons.json file #10085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2023
Merged

chore: add icons.json file #10085

merged 4 commits into from
Oct 6, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Oct 5, 2023 •
edited
Loading

Leading up to #8344

We need a way for the app to know all of the bundled icons so that we can better expose them throughout the UI

BrunoQuaresma
BrunoQuaresma approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really liked the idea 😃

kylecarbs
kylecarbs approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Can we add these to our emoji-picker? We also may want to import the icons.json file from JS so it's embedded rather than have to make a network request for it.

matifali
matifali approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@aslilac
Copy link
Member Author

aslilac commented Oct 5, 2023

Can we add these to our emoji-picker?

Yes!

We also may want to import the icons.json file from JS so it's embedded rather than have to make a network request for it.

Good point! I'll generate it somewhere in src/ instead

matifali
matifali reviewed Oct 5, 2023
View reviewed changes
@aslilac aslilac merged commit 71ad590 into main Oct 6, 2023
@aslilac aslilac deleted the icons-json branch October 6, 2023 19:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aslilac @BrunoQuaresma @kylecarbs @matifali