Skip to content

fix: use proper react hook for favicon theme #10094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix: use proper react hook for favicon theme #10094

merged 1 commit into from
Oct 5, 2023

Conversation

kylecarbs
Copy link
Member

I was using useState before, which didn't re-render on load.

@kylecarbs kylecarbs self-assigned this Oct 5, 2023
@kylecarbs kylecarbs enabled auto-merge (squash) October 5, 2023 23:07
cdr-bot[bot]
cdr-bot bot approved these changes Oct 5, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@kylecarbs kylecarbs disabled auto-merge October 5, 2023 23:18
@kylecarbs
fix: use proper react hook for favicon theme
569101c 
I was using `useState` before, which didn't re-render on load.
@kylecarbs kylecarbs merged commit d24d2d2 into main Oct 5, 2023
@kylecarbs kylecarbs deleted the fixfavicontheme branch October 5, 2023 23:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylecarbs